Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: Introduces OciSecretsMpMetaConfigProvider, which adapts OciSecretsConfigSourceProvider to the MpMetaConfigProvider contract #7555

Merged
merged 1 commit into from
Sep 13, 2023
Merged

3.x: Introduces OciSecretsMpMetaConfigProvider, which adapts OciSecretsConfigSourceProvider to the MpMetaConfigProvider contract #7555

merged 1 commit into from
Sep 13, 2023

Conversation

ljnelson
Copy link
Member

@ljnelson ljnelson commented Sep 8, 2023

Straightforward backport of #7520.

Documentation impact: none

@ljnelson
Introduces OciSecretsMpMetaConfigProvider, which adapts OciSecretsCon…
a18b963 
…figSourceProvider to the MpMetaConfigProvider contract

Signed-off-by: Laird Nelson <[email protected]>
@ljnelson ljnelson added MP config P2 3.x Issues for 3.x version branch OCI backport Issues that are merged into a single branch, but missing in either master or previous release labels Sep 8, 2023
@ljnelson ljnelson self-assigned this Sep 8, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 8, 2023
@ljnelson
Copy link
Member Author

ljnelson commented Sep 8, 2023

Addresses #4238.

@ljnelson ljnelson changed the title Introduces OciSecretsMpMetaConfigProvider, which adapts OciSecretsConfigSourceProvider to the MpMetaConfigProvider contract 3.x: Introduces OciSecretsMpMetaConfigProvider, which adapts OciSecretsConfigSourceProvider to the MpMetaConfigProvider contract Sep 8, 2023
@ljnelson ljnelson mentioned this pull request Sep 8, 2023
Closed
arjav-desai
arjav-desai approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@arjav-desai arjav-desai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as the main change is approved in 4.x

@ljnelson ljnelson merged commit 0b2952a into helidon-io:helidon-3.x Sep 13, 2023
12 checks passed
This was referenced Sep 13, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjav-desai arjav-desai arjav-desai approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

Assignees

@ljnelson ljnelson

Labels
3.x Issues for 3.x version branch backport Issues that are merged into a single branch, but missing in either master or previous release config MP OCA Verified All contributors have signed the Oracle Contributor Agreement. OCI P2
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljnelson @arjav-desai